Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate Node impl to alloy-primitives type and simplify #145

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

ralexstokes
Copy link
Owner

@ralexstokes ralexstokes commented Apr 1, 2024

Fixes #114.

Primarily, migrate Node to alloy_primitives::B256 to drop how much custom code we need

Also starts to lay the ground work for a similar refactor in ethereum-consensus to drop more custom serde code there (particularly around bytes and hex munging).

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 77.96610% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 64.71%. Comparing base (13d2c7d) to head (644a576).

❗ Current head 644a576 differs from pull request most recent head 2c5d56c. Consider uploading reports for the commit 2c5d56c to get more accurate results

Files Patch % Lines
ssz-rs/src/merkleization/multiproofs.rs 0.00% 8 Missing ⚠️
ssz-rs/src/merkleization/merkleize.rs 66.66% 3 Missing ⚠️
ssz-rs/src/merkleization/node.rs 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   65.86%   64.71%   -1.16%     
==========================================
  Files          20       19       -1     
  Lines        1201     1176      -25     
==========================================
- Hits          791      761      -30     
- Misses        410      415       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ralexstokes ralexstokes force-pushed the migrate-to-alloy branch 6 times, most recently from 13413d2 to 79ae7f1 Compare April 1, 2024 19:04
ssz-rs/src/lib.rs Outdated Show resolved Hide resolved
@ralexstokes ralexstokes merged commit 727f50e into main Apr 1, 2024
3 checks passed
@ralexstokes ralexstokes deleted the migrate-to-alloy branch April 1, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explore migrating merkleization::Node to the alloy-primitives fixed bytes 32 type
1 participant