Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Map #49

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix: Map #49

merged 1 commit into from
Jun 29, 2023

Conversation

Harris-Miller
Copy link
Collaborator

Map should not return KeyOfUnion when handling objects, it isn't typesafe. You don't know what keys the object will actually have. Just using keyof U will be the same keys as what is similar to the union types, which is what you get in typescript until you narrow the type

@Harris-Miller Harris-Miller merged commit bec8135 into develop Jun 29, 2023
@Harris-Miller Harris-Miller deleted the map-2 branch June 29, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant