Support RAML 1.0 resource types declaration

[rgzp]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 460

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• 9 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.05%) to 80.068%

---

Files with Coverage Reduction	New Missed Lines	%
src/NamedParameter.php	1	83.81%
src/Types/TypeValidationError.php	1	90.57%
src/Validator/ContentConverter.php	1	56.25%
src/Utility/TraitParserHelper.php	6	58.82%

Totals
Change from base Build 458:	0.05%
Covered Lines:	3756
Relevant Lines:	4691

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 466

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 80.142%

---

Totals
Change from base Build 458:	0.1%
Covered Lines:	12983
Relevant Lines:	16200

---

💛 - Coveralls

[rgzp]

RAML 1.0 specification declares resource types as array, while 0.8 was array of arrays.

[martin-georgiev]

It looks odd that $ramlData['resourceTypes'] is processed twice. This doesn't feel right.

[rgzp]

Sorry about that, removed unnecessary code.

[martin-georgiev]

Readability can be improved by extracting the if body in a submethod, eg private function isRaml08(string|int $key): bool. Indentation levels can also be simplified by replacing the else consrtuction with continue as part of the if.

The final code will read something like:

foreach ($ramlData['resourceTypes'] as $key => $resourceType) {
  if ($this->isRaml08($key)) {
    ... // logic to process 0.8 resource types
    continue; 
  }
  ... // logic to process 1.0 resource types
}


...


/**
 * @param string|int $key
 * @return bool
 */
private function isRaml08($key)
{
  return \is_int($key);
}

[rgzp]

Done. To reduce cognitive complexity we can move out this part of code in "getKeydedResourceTypes" method.
As we need exactly one or two cycles on resourceTypes, there are almost nothing to improve in code itself. Maybe recursive getKeyedResourceTypes call will look better but it leads to unnecessary array_merge for v0.8.

[martin-georgiev]

I don't think a recursive approach is the best one here as there is a known and very low number of iterations. A recursive approach can easily clear the way for otherwise broken, over-nested resources.

[martin-georgiev]

@rgzp thank you for this contribution and the speedy changes.