Merge pull request #11 from ramonaoptics/use_unsigned_values

Ensure that analog reads return unsigned values
ramonaoptics · Jul 14, 2021 · fd12baf · fd12baf
2 parents 60535ea + fcd9d3f
commit fd12baf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 0.0.16
+
+* Bugfix: Ensure that analog reads return unsigned values.
+
 ### 0.0.15
 
 * Add the ability to do analog reads.

diff --git a/src/main.cpp b/src/main.cpp
@@ -315,7 +315,7 @@ int gpio_digital_read(CommandRouter *cmd, int argc, const char **argv) {
   uint8_t pin = strtol(argv[1], nullptr, 0);
   uint8_t value = digitalRead(pin);
 
-  snprintf(cmd->buffer, cmd->buffer_size, "%d", value);
+  snprintf(cmd->buffer, cmd->buffer_size, "%u", value);
   return 0;
 }
 
@@ -339,7 +339,7 @@ int analog_read(CommandRouter *cmd, int argc, const char **argv) {
   uint8_t pin = strtol(argv[1], nullptr, 0);
   uint8_t value = analogRead(pin);
 
-  snprintf(cmd->buffer, cmd->buffer_size, "%d", value);
+  snprintf(cmd->buffer, cmd->buffer_size, "%u", value);
   return 0;
 }