Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing feature for PartialEq and Hash with comparison of Sha256 hashed values for secrets #232

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

kate-shine
Copy link
Contributor

following advice in
#107 (comment)
added a feature that allows safer comparisons of secret values that should be resistant to timing attacks.

@ramosbugs
Copy link
Owner

thanks for the PR! I think cargo fmt is complaining about trailing whitespace

@kate-shine
Copy link
Contributor Author

thanks for the PR! I think cargo fmt is complaining about trailing whitespace

Thanks, fixed! It might be a good idea to add a more opinionated rustfmt.toml to repo :) I didn't autoformate, because my rustfmt settings changed way more than what my contribution contained.

Thanks for great crates, by the way :) I'm currently using them for MS Entra and it's a super smooth experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants