Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Containers Page #305

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

sunilarjun
Copy link
Contributor

Containers section added to the user interface dropdown. Description of components and management buttons, the images will be updated with S3 images once the screeenshots are finalized.

…of components and management buttons, the images will be updated with S3 images once the screeenshots are finalized.

Signed-off-by: Sunil Singh <sunil.singh@suse.com>
@sunilarjun sunilarjun requested a review from nunix October 18, 2023 23:22
@sunilarjun sunilarjun marked this pull request as ready for review October 19, 2023 15:07
Copy link
Contributor

@nunix nunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared the following feedback with Sunil:

  • Update the images
  • Move the Dashboard details after the first sentence
  • Add a Container Management intro
  • Add a description for the actions icon (three vertical dots)

@sunilarjun sunilarjun marked this pull request as draft October 20, 2023 15:57
Signed-off-by: Sunil Singh <sunil.singh@suse.com>
Copy link
Contributor

@nunix nunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased the container management intro.

Please feel free to adapt in order to keep the initial meaning of the sentence (if it changed).

docs/ui/containers.md Outdated Show resolved Hide resolved
Signed-off-by: Sunil Singh <sunil.singh@suse.com>
@sunilarjun sunilarjun marked this pull request as ready for review October 24, 2023 15:02
@sunilarjun sunilarjun merged commit cc6750b into rancher-sandbox:main Oct 24, 2023
2 checks passed
@sunilarjun
Copy link
Contributor Author

This work is tied to rancher-sandbox/rancher-desktop#4506.

@sunilarjun sunilarjun deleted the add-containers-page branch November 2, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants