Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cisProfile option broken with ignition format #401

Closed
hardys opened this issue Aug 12, 2024 · 1 comment · Fixed by #402
Closed

cisProfile option broken with ignition format #401

hardys opened this issue Aug 12, 2024 · 1 comment · Fixed by #402
Assignees
@hardys
Labels
kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@hardys
Copy link
Contributor

hardys commented Aug 12, 2024

What happened:
Deploying with a configuration like this is currently broken due to formatting issues in the butane config:

    cisProfile: cis-1.23
    format: ignition

What did you expect to happen:
The cisProfile option should enable the rke2-cis-script.sh inside the rendered rke2-install.sh however due to stray tabs in the template it fails with an error like:

E0810 07:53:11.578031       1 controller.go:329] "Reconciler error" err="converting base config to Ignition: error converting to Ignition: yaml: line 712: found a tab character where an indentation space is expected" controller="rke2config" controllerGroup="bootstrap.cluster.x-k8s.io"

How to reproduce it:

Deploy with cisProfile and ignition format enabled

Environment:
Only impacts ignition format deployments AFAICS, e.g Leap/SLEMicro
@hardys hardys added kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 12, 2024
@hardys
Copy link
Contributor Author

hardys commented Aug 12, 2024

I'm working on a fix for this so please assign the issue to me, thanks!

hardys added a commit to hardys/cluster-api-provider-rke2 that referenced this issue Aug 12, 2024
@hardys
Fix cisProfile option with ignition format
17d5d28 
Currently there are some stray tabs which break the rendered output,
replace these with spaces and add some unit test coverage.

Fixes: rancher#401
@hardys hardys mentioned this issue Aug 12, 2024
Merged
4 tasks
hardys added a commit to hardys/cluster-api-provider-rke2 that referenced this issue Aug 15, 2024
@hardys
Fix cisProfile option with ignition format
471a981 
Currently there are some stray tabs which break the rendered output,
replace these with spaces and add some unit test coverage.

Fixes: rancher#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hardys hardys

Labels
kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cisProfile option with ignition format hardys/cluster-api-provider-rke2
1 participant
@hardys