Drop out legacy and add default upgrade e2e tests #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange, e2e tests are terminating (https://github.com/rancher/cluster-api-provider-rke2/actions/runs/10281104489/job/28450906458?pr=398, https://github.com/rancher/cluster-api-provider-rke2/actions/runs/10281104489/job/28449894374?pr=398) out of nowhere in the middle and it fails.. no logs, no traces, nothing 😮💨 |
|
New e2e tests are not running in suite, checking it. |
furkatgofurov7
force-pushed
the
separate-legacy-upgrade-tests
branch
10 times, most recently
from
3069a52 to
4149e41
Compare
furkatgofurov7
changed the title
furkatgofurov7
force-pushed
the
separate-legacy-upgrade-tests
branch
2 times, most recently
from
5a0aa17 to
d6a51dc
Compare
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
e2e image building is already part of the 'make e2e-tests' Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
furkatgofurov7
force-pushed
the
separate-legacy-upgrade-tests
branch
from
d6a51dc to
ec2b27b
Compare
Danil-Grigorev
approved these changes
Aug 13, 2024
alexander-demicev
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Drop legacy upgrade tests (v0.2.7->v0.3.0) and related code introduced in a7b3b2f#diff-868dcd8976a79a1736e0bfe328a5100bd09c295509f0c3edd3f1d6baa72ff4aa
and add back default upgrade (v0.4.0->v0.5.0) e2e tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: