fix: use absolute path to rke2's kubectl binary #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
approved these changes
Aug 13, 2024
alexander-demicev
approved these changes
Aug 13, 2024
|
@simplysoft we require commits to be signed, this blocks the PR from being merged. Can you fix that? |
Sure, didn't find contribution guidelines on first sight, so missed that sorry |
simplysoft
force-pushed
the
fix/kubectl-not-found
branch
from
8dd5625 to
cf224b9
Compare
Danil-Grigorev
approved these changes
Aug 13, 2024
furkatgofurov7
approved these changes
Aug 13, 2024
|
I re-triggered e2e tests and they will hopefully pass, if not, please rebase the branch with main to include the latest e2e fixes and we will re-run them again. |
This will need a rebase |
ensures that cluster-etcd secret can be created if host does not have kubectl installed fixes rancher#403 Signed-off-by: Simplysoft GmbH <1588210+simplysoft@users.noreply.github.com>
auto-merge was automatically disabled
August 13, 2024 14:11
Head branch was pushed to by a user without write access
simplysoft
force-pushed
the
fix/kubectl-not-found
branch
from
cf224b9 to
1412bb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensures that cluster-etcd secret can be created if host does not have kubectl installed
fixes #403
kind/bug
Checklist: