Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factoring plugin installation out of index.js. #10654

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

codyrancher
Copy link
Contributor

One of a series of changes to simplify the bootstrapping and authentication code.

@codyrancher codyrancher force-pushed the plugin-simplification branch from f932903 to 097108f Compare March 19, 2024 22:25
@codyrancher codyrancher requested a review from aalves08 March 19, 2024 23:49
@codyrancher codyrancher marked this pull request as ready for review March 19, 2024 23:49
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the initiative <3
If would you not mind, could we please adjust these 2 parts?

shell/initialize/plugins.js Outdated Show resolved Hide resolved
shell/initialize/plugins.js Outdated Show resolved Hide resolved
One of a series of changes to simplify the bootstrapping and authentication code.
@codyrancher codyrancher force-pushed the plugin-simplification branch from 097108f to 9e5cce3 Compare March 20, 2024 19:37
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyrancher codyrancher merged commit cc4dbdf into rancher:master Mar 20, 2024
24 checks passed
@cnotv cnotv mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants