Removing the unauthenticated middleware #10920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyrancher
force-pushed
the
unauthenticated-removal
branch
from
47d5e41 to
6f7c296
Compare
codyrancher
commented
Apr 30, 2024
Comment on lines
-94
to
-97
| // Set the favicon - use custom one from store if set | ||
| if (!haveSetFavIcon()) { | ||
| setFavIcon(store); | ||
| } |
There was a problem hiding this comment.
The brand mixin is used everywhere that the authenticated middleware is used so this should be fine.
codyrancher
commented
Apr 30, 2024
| @@ -1,7 +1,3 @@ | |||
| <script> | |||
There was a problem hiding this comment.
This is for standalone plugins. They should have their own branding so I didn't switch this with the Brand mixin.
rak-phillip
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing the unauthenticated middleware
Technical notes summary
Migrated the favorite icon logic out of the un/authenticated middlewares into the brand mixin.
Even though I'm not a fan of mixins I think the grouping at least makes sense given the favorite icon is one of several brand settings.
Areas or cases that should be tested
Unauthenticated pages, really just the login page.
Screenshot/Video
The flashing is present in master as well so this isn't a regression. We should consider caching all brand settings in cookies like we do with light/dark mode.
https://github.com/rancher/dashboard/assets/55104481/7a59c8f5-54b9-4109-95bf-ab8b3d172e4d
Checklist