Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cookie-universal-nuxt dependency #11354

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Jul 3, 2024

Summary

This replaces the cookie-universal-nuxt dependency with cookie-universal.

cookie-universal-nuxt was essentially a wrapper around cookie-universal, so it's a fairly straightforward swap for the underlying dependency; the version of cookie-univerval that we chose is already a transitive dependency, this PR simply makes it direct.

Fixes #11321

Occurred changes and/or fixed issues

  • replace cookie-universal-nuxt dependency with cookie-universal

Areas or cases that should be tested

  • assert that cookie behavior does not regress

Areas which could experience regressions

  • setting, getting, and deleting cookies could regress

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip changed the title Feature/11321 cookie Replace cookie-universal-nuxt dependency Jul 9, 2024
@rak-phillip rak-phillip added the kind/tech-debt Technical debt label Jul 9, 2024
@rak-phillip rak-phillip marked this pull request as ready for review July 9, 2024 16:00
@rak-phillip rak-phillip merged commit 7b34ee4 into rancher:master Jul 26, 2024
36 checks passed
@rak-phillip rak-phillip deleted the feature/11321-cookie branch July 26, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech-debt Technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cookie-universal-nuxt with a more generic library
2 participants