Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @nuxt/babel-preset-app with @babel/preset-env #11432

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Jul 12, 2024

Summary

This replaces @nuxt/babel-preset-app with @babel/preset-env to support the effort of replacing nuxt dependencies throughout Dashboard.

Fixes #11375

Technical notes summary

It's important to note that @babel/preset-env@7.21.4 is a transitive dependency of @vue/cli-plugin-babel that's hoisted from rancher components

➤ yarn why @babel/preset-env                                                                        
yarn why v1.22.19
[1/4] Why do we have the module "@babel/preset-env"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "@babel/preset-env@7.21.4"
info Reasons this module exists
   - "_project_#@rancher#components#@vue#cli-plugin-babel#@vue#babel-preset-app" depends on it
   - Hoisted from "_project_#@rancher#components#@vue#cli-plugin-babel#@vue#babel-preset-app#@babel#preset-env"
info Disk size without dependencies: "384KB"
info Disk size with unique dependencies: "7.11MB"
info Disk size with transitive dependencies: "26.82MB"
info Number of shared dependencies: 116
Done in 0.84s.

We can consider listing this as a dev dependency for shell.

Areas which could experience regressions

  • Dashboard builds, production builds should be validated and compared with builds from before this change was introduced
  • Features that use modern JavaScript syntax or rely on polyfills could be missing if they were provided by @nuxt/babel-preset-app

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.0 milestone Jul 12, 2024
@cnotv cnotv self-requested a review July 12, 2024 18:21
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip changed the title Remove @nuxt/babel-preset-app Replace @nuxt/babel-preset-app with @babel/preset-env Jul 12, 2024
@rak-phillip rak-phillip marked this pull request as ready for review July 12, 2024 20:02
@rak-phillip rak-phillip merged commit d232aae into rancher:master Jul 26, 2024
39 checks passed
@rak-phillip rak-phillip deleted the chore/remove-nuxt-babel branch July 26, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace @nuxt/babel-preset-app loader with explicit configuration
2 participants