Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type for mechanism to allow to register custom pages conditionally (based on resource type) #12907

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

aalves08
Copy link
Member

Summary

Fixes #12899 (low bar fix)

Occurred changes and/or fixed issues

  • add ifHave property to types + bump shell

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 requested a review from jordojordo December 18, 2024 12:33
@aalves08 aalves08 self-assigned this Dec 18, 2024
@aalves08 aalves08 merged commit e1da199 into rancher:master Dec 18, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a mechanism to allow to register custom pages conditionally
2 participants