e2e test that creates GKE cluster with default settings #12934
Conversation
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
| @@ -34,4 +34,8 @@ export default class BaseCloudCredentialsPo extends PagePo { | |||
| saveButton() { | |||
| return new AsyncButtonPo('[data-testid="form-save"]', this.self()); | |||
| } | |||
|
|
|||
| authenticateButton() { | |||
There was a problem hiding this comment.
to confirm this button exists on multiple credentials pages?
There was a problem hiding this comment.
Not as far as I know. at least not for the existing test coverage nor in the default providers available in the cluster provisioning menu. Do you want me then to move it to the cloud credential gke page object?
| <div class="col span-6"> | ||
| <div | ||
| class="col span-6" | ||
| data-testid="name-ns-description-name" |
There was a problem hiding this comment.
name-ns-description is a component which has this testid, it's best to give this one and below unique names
There was a problem hiding this comment.
though both could be avoided by using a selector something like this [data-testid="crugke-form"] .labeled-input:nth-of-type(x)
There was a problem hiding this comment.
I prefer to keep this selector, as I'm utilizing the functions of this component in my tests (lines 62, 91, and 93), and these selectors are used across other tests that validate provisioning clusters with different cloud providers to reference the same fields: cluster name and cluster description. I believe this avoids duplication of code.
There was a problem hiding this comment.
The shell/components/form/NameNsDescription.vue component contains the unique testid of name-ns-description-name already. It's used specifically to find the name label select within that NameNsDescription component.
In pkg/gke/components/CruGKE.vue though it doesn't use the NameNsDescription component, so testid's should not copy the already taken id's from the NameNsDescription component and e2e tests should not use the cypress/e2e/po/components/name-ns-description.po.ts PO.
| if (item.googlecredentialConfig) { | ||
| const id = item.id; | ||
|
|
||
| cy.deleteRancherResource('v3', 'cloudcredentials', id); |
There was a problem hiding this comment.
This will delete all gke credentials on the target rancher, without knowing it was there developers could lose them.
Can the test be updated to be agnostic of existing credentials?
There was a problem hiding this comment.
I could make this test agnostic to existing credentials, but the current cluster provisioning tests for the other cloud providers perform the same cleanup step.
cluster-provisioning-amazon-ec2-rke1.spec.ts and cluster-provisioning-amazon-ec2-rke2.spec.ts perform it before the tests whereas cluster-provisioning-azure-rke1.spec.ts and cluster-provisioning-azure-rke2.spec.ts perform it after the tests. My suggestion is to keep the cleanup step.
There was a problem hiding this comment.
It looks like the other tests have a large message at the top of the file warning of the consequences of running the test. Lo-bar solution is to ensure that's added here too.
Note - the cleanup in all the referenced files only removes the cloud cred that the test created, rather than the ideal step of returning the environment back to how it was before the tests run.
cypress/e2e/tests/pages/manager/gke-cluster-provisioning.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
| cy.intercept('GET', '/v1/management.cattle.io.users?exclude=metadata.managedFields').as('pageLoad'); | ||
| cloudCredForm.saveCreateForm().cruResource().saveAndWaitForRequests('POST', '/v3/cloudcredentials').then((req) => { | ||
| expect(req.response?.statusCode).to.equal(201); | ||
| cloudcredentialId = req.response?.body.id.replace(':', '%3A'); |
There was a problem hiding this comment.
This should be removed post test
Edit: the cloud cred should be deleted post test
Summary
Occurred changes and/or fixed issues
This PR addresses the issue rancher/qa-tasks#1571.
This is a single e2e test that creates a GKE cluster with the default settings and verifies that the cluster is created and that the GKE default version and zone are displayed in the UI elements as expected. To support the test, were created GKE-related page objects for the GKE Create cloud credentials page, the GKE authenticate page with Project ID, and the Create GKE Cluster Page.
Some methods and variables were created but are not being used in this single test. Still, they will be used for the upcoming tests.
Storing the GKE Cloud credentials will be addressed in another PR.
Areas or cases that should be tested
Create a GKE Cluster with default settings
Other cluster provisioning-related tests
Other cloud credentials creation related tests
Other pages that contain LabeledInput or LabeledSelect elements
Areas which could experience regressions
other cluster provisioning tests
Checklist