Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct container registry for latest 2.9 head builds #12935

Open
wants to merge 2 commits into
base: release-2.9
Choose a base branch
from
Open

Use correct container registry for latest 2.9 head builds #12935

wants to merge 2 commits into from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Dec 23, 2024 •
edited
Loading

Summary

Fixes: #12936

Occurred changes and/or fixed issues

  • without this it doesn't look like rancher serves up the correct CNi charts related to the version of kube (1.28 and below are fine, 1.29 and above will fail to fetch charts)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.9.6 milestone Dec 23, 2024
@richard-cox richard-cox requested a review from aalves08 December 23, 2024 13:33
@richard-cox richard-cox self-assigned this Dec 23, 2024
@richard-cox richard-cox mentioned this pull request Dec 23, 2024
Merged
@richard-cox richard-cox changed the title User correct container registry for latest 2.9 head builds Use correct container registry for latest 2.9 head builds Dec 23, 2024
@richard-cox
Copy link
Member Author

Note - this is blocked on eio 2933

@richard-cox
Copy link
Member Author

richard-cox commented Dec 23, 2024 •
edited
Loading

#12937 should be reverted after this merges

aalves08
aalves08 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalves08 aalves08 aalves08 approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @aalves08