Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyboard nav on login screen #12956

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Dec 27, 2024

Summary

Fixes #12775

Occurred changes and/or fixed issues

  • Fix keyboard navigation on login screen
  • checkbox is now visibly focusable
  • add role="button" to AsyncButton
  • Password component is now tabbable
  • refactor LocaleSelector component to work with keyboard navigation (login mode only)

Technical notes summary

Areas or cases that should be tested

  • Go to the login screen and browse the page with the tab key
  • use enter or space key to trigger UI elements on the page

Areas which could experience regressions

Screenshot/Video

Screen.Recording.2024-12-27.at.15.31.14.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.11.0 milestone Dec 27, 2024
@aalves08 aalves08 self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation, role, aria-label and focus display issues on the login screen
1 participant