Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries to Vue3 and related configuration #9171

Closed

Conversation

cnotv
Copy link
Contributor

@cnotv cnotv commented Jun 21, 2023

Summary

Fixes #9539

This is the base branch for https://github.com/rancher/dashboard/tree/vue3

Run these scripts to complete the migration before test:

  • yarn migrate
  • npx vue-upgrade-tool --files 'shell/**/*.test.ts'
  • yarn lint --fix

Occurred changes and/or fixed issues

Technical notes summary

Follow documentation instructions in a master branch of the dashboard or an extension and try to run/build the project.

Several missing cases not mentioned in the Vue migrations have been deprecated/removed:

  • Vue.set
  • Vue.delete
  • $slots as functions
  • multiple v-model
  • .native
  • slot-scope

Replaced Vue reserved names fixed with #11030

Added missing library requested from Webpack:

  • cache-loader: ^4.1.0
  • node-polyfill-webpack-plugin: ^3.0.0, now removed in Vue3 and required to be added manually

Corrected issues not allowed in Vue3:

  • import of non default export (e.g. plugins)

Deprecated code:

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@cnotv cnotv self-assigned this Jun 21, 2023
@github-actions github-actions bot added this to the v2.7.next3 milestone Jun 21, 2023
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch 2 times, most recently from c86edee to 0eaa722 Compare June 21, 2023 16:09
@richard-cox richard-cox modified the milestones: v2.7.next3, v2.8.next4 Jul 19, 2023
@cnotv cnotv changed the title Migration to Vue 3 Investigation for Vue3 migration Aug 15, 2023
@nwmac nwmac modified the milestones: v2.8.0, v2.8.next1 Sep 27, 2023
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch 4 times, most recently from e2e5fe4 to 6b888b1 Compare November 29, 2023 19:15
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch from 6b888b1 to cadb836 Compare January 12, 2024 16:51
@cnotv cnotv changed the title Investigation for Vue3 migration Update libraries to Vue3 and related configuration Jan 12, 2024
@github-actions github-actions bot modified the milestones: v2.9.0, v2.8.0 Jan 12, 2024
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch 11 times, most recently from 6d3d13a to 7b3a218 Compare January 17, 2024 10:27
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch from 309dbfc to 37b41e8 Compare August 9, 2024 16:01
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch 2 times, most recently from 2cb1a6a to 7b5e05b Compare August 12, 2024 10:41
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch from 7b5e05b to 40421ba Compare August 12, 2024 10:51
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@cnotv cnotv force-pushed the feature/9028-investigate-vue3-migration branch from be6588e to dee468d Compare August 12, 2024 13:43
@cnotv
Copy link
Contributor Author

cnotv commented Sep 3, 2024

Closing as we merged already another PR in the end :)

@cnotv cnotv closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e Forcibly skip E2E tests in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Vue3 libraries and related configuration
4 participants