-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libraries to Vue3 and related configuration #9171
Closed
cnotv
wants to merge
40
commits into
rancher:master
from
cnotv:feature/9028-investigate-vue3-migration
Closed
Update libraries to Vue3 and related configuration #9171
cnotv
wants to merge
40
commits into
rancher:master
from
cnotv:feature/9028-investigate-vue3-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
2 times, most recently
from
June 21, 2023 16:09
c86edee
to
0eaa722
Compare
12 tasks
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
4 times, most recently
from
November 29, 2023 19:15
e2e5fe4
to
6b888b1
Compare
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
from
January 12, 2024 16:51
6b888b1
to
cadb836
Compare
cnotv
changed the title
Investigation for Vue3 migration
Update libraries to Vue3 and related configuration
Jan 12, 2024
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
11 times, most recently
from
January 17, 2024 10:27
6d3d13a
to
7b3a218
Compare
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
from
August 9, 2024 16:01
309dbfc
to
37b41e8
Compare
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
2 times, most recently
from
August 12, 2024 10:41
2cb1a6a
to
7b5e05b
Compare
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
from
August 12, 2024 10:51
7b5e05b
to
40421ba
Compare
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
cnotv
force-pushed
the
feature/9028-investigate-vue3-migration
branch
from
August 12, 2024 13:43
be6588e
to
dee468d
Compare
Closing as we merged already another PR in the end :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9539
This is the base branch for https://github.com/rancher/dashboard/tree/vue3
Run these scripts to complete the migration before test:
yarn migrate
npx vue-upgrade-tool --files 'shell/**/*.test.ts'
yarn lint --fix
Occurred changes and/or fixed issues
Technical notes summary
Follow documentation instructions in a master branch of the dashboard or an extension and try to run/build the project.
Several missing cases not mentioned in the Vue migrations have been deprecated/removed:
Vue.set
Vue.delete
$slots
as functionsv-model
.native
slot-scope
Replaced Vue reserved namesfixed with #11030Added missing library requested from Webpack:
cache-loader: ^4.1.0
node-polyfill-webpack-plugin: ^3.0.0
, now removed in Vue3 and required to be added manuallyCorrected issues not allowed in Vue3:
Deprecated code:
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video