-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added router to rediect github auth #9262
Added router to rediect github auth #9262
Conversation
This used to work pre-Nuxt removal - this was handled by This was removed when we removed Nuxt - although the We should be able to wire NOTE: This needs to be wired in ONLY when running in dev locally - which the above would do - the current code in this PR wires this in, in all cases. @richard-cox ^^^ |
fb82b4b
to
58444c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hasn't covered part of the request from #9138 (comment)
- the process to add server middleware via the old
serverMiddleware
array is still inshell/vue.config.js
. At the very leastserverMiddleware.push(path.resolve(dir, SHELL, 'server', 'server-middleware'));
should be removed - there's no clear way forward to address that now defunct old method using the
serverMiddleware
array (specifically the other parts that don't work in post nuxt world). Can you create an issue to cover them?
I have removed unused code and created an issue for |
3e32ece
to
2f2f542
Compare
Summary
Fixes #9138
Fixed issue - Unable to use Auth Providers when running locally
To test
setup github auth provider