Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify default partition sizes #565

Closed
4 tasks done
Tracked by #224
mudler opened this issue Aug 31, 2021 · 2 comments
Closed
4 tasks done
Tracked by #224

Allow to specify default partition sizes #565

mudler opened this issue Aug 31, 2021 · 2 comments
Assignees
Labels
area/harvester kind/branding and customization Issues related to derivative customizations and branding kind/enhancement New feature or request

Comments

@mudler
Copy link
Contributor

mudler commented Aug 31, 2021

Is your feature request related to a problem? Please describe.
At the moment we hardcode the partition size in cos-installer and more importantly we have hardcoded image size during upgrade/reset. This might work for all the cases, but makes sense to expose this to the configuration since it might not suit all cases.

Describe the solution you'd like
A way to override default configs with our general config file, or alternatively via cloud-init:

  • Partition sizes
  • Partition types (at least should be possible to specify ext4)
  • Default image size (.img files created during upgrades)
  • Default COS_PERSISTENT device location

Describe alternatives you've considered
N/A

Additional context
Hardcoded image size:
https://github.com/rancher-sandbox/cOS-toolkit/blob/master/packages/installer/upgrade.sh#L113
Hardcoded partition size:
https://github.com/rancher-sandbox/cOS-toolkit/blob/master/packages/installer/installer.sh#L111

@mudler mudler added kind/enhancement New feature or request kind/branding and customization Issues related to derivative customizations and branding labels Aug 31, 2021
@mudler mudler self-assigned this Aug 31, 2021
@mudler mudler removed their assignment Aug 31, 2021
@mudler
Copy link
Contributor Author

mudler commented Oct 19, 2021

Depends on #771

@mudler mudler added the status/blocked Issue depends on another one label Oct 19, 2021
@mudler mudler removed the status/blocked Issue depends on another one label Oct 21, 2021
@mudler
Copy link
Contributor Author

mudler commented Nov 3, 2021

As a first pass, makes sense to explore if we can do the partitioning with the cloud-init tool, so:

  • We have one tool only to handle partitioning logics
  • It is tested - the cloud-init tool layout plugin have unit tests and can be easily maintained
  • We can allow the user to provide optionally a cloud-config file with the installation partitioning schema

In this way, we don't have to re-implement any partitioning logic into the bash CLI, but we can just generate a cloud-config on-the-fly during installation (or just ship sane defaults), if the user didn't provided one

@mudler mudler self-assigned this Nov 3, 2021
mudler added a commit that referenced this issue Nov 3, 2021
Fixes #565
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler added a commit that referenced this issue Nov 4, 2021
Fixes #565
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler closed this as completed in 3b9d49f Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/harvester kind/branding and customization Issues related to derivative customizations and branding kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant