Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider rewriting the autobumper in golang #654

Closed
mudler opened this issue Sep 16, 2021 · 0 comments
Closed

Consider rewriting the autobumper in golang #654

mudler opened this issue Sep 16, 2021 · 0 comments
Labels
kind/enhancement New feature or request kind/refactoring areas of code that needs refactoring

Comments

@mudler
Copy link
Contributor

mudler commented Sep 16, 2021

Is your feature request related to a problem? Please describe.
The autobumper which is responsible of @cOS-cibot automated PRs is currently implemented in bash and using yq (https://github.com/Luet-lab/extensions/blob/master/extensions/autobump-github/luet-autobump-github). Although it works, it reached it's implementation limits and the lack of tests makes hard to implement new features

Describe the solution you'd like

A reimplementation of the auto-bumper, for e.g. in golang, complete of test-suite.

During #602 (comment) for example we could have introduced the ability to handle different package versions in the same tree, as the bash version now just does handle bumps by editing the specfiles in place.

A WIP comprensive of unit tests is here: https://github.com/mudler/luet-autobumper, it is not feature-parity yet with the bash equivalent but it already auto-bumps inplace or either add new spec files to the tree. It also handles reverse dependencies correctly.

Describe alternatives you've considered
Currently with #653 we address to #602 by allowing all the released-ever metadata to be installed. We download the available metadata in the repository before publishing the new tree version.

Additional context
See #602 and #653

@mudler mudler added kind/enhancement New feature or request kind/refactoring areas of code that needs refactoring labels Sep 16, 2021
@mudler mudler self-assigned this Sep 16, 2021
@mudler mudler removed their assignment Sep 17, 2021
@mudler mudler moved this to ❆ Icebox in Elemental Jun 1, 2022
@mudler mudler added this to Elemental Jun 1, 2022
@kkaempf kkaempf removed this from Elemental Jul 26, 2022
@frelon frelon closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/refactoring areas of code that needs refactoring
Projects
None yet
Development

No branches or pull requests

2 participants