Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retain old package versions in the published tree #653

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Sep 16, 2021

Adds DOWNLOAD_ALL to add old packages back in the index, and enables it
on the publishing pipeline. This will cause the tree to see the old
packages and make them available for installation.

--> BUILD --> PULL all metadata 
           -> Create repository (with `--from-metadata`) -> PUBLISH

Requires luet 0.17.10 mudler/luet@e4fff77

Fixes #602

Blocked as requires luet 0.17.10 and needs some manual sanity check as it touches internals and could cause issues..

Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com

Copy link
Contributor

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess? Need to check the luet change to be sure :D

@mudler
Copy link
Contributor Author

mudler commented Sep 16, 2021

I guess? Need to check the luet change to be sure :D

sorry, updated the issue. the change is actually really small mudler/luet@e4fff77 , it's more about testing it. I'm concerned we might see some issues here with packages that are not really semver compliant, so double checking that.

@mudler mudler force-pushed the add_old_packages_to_index branch 2 times, most recently from 014df52 to f821a19 Compare September 17, 2021 07:44
@mudler
Copy link
Contributor Author

mudler commented Sep 17, 2021

mh. couldn't work as nicely as I thought, could it :) seems to work but it takes build dependencies as runtime mudler/luet@e4fff77. so it needs further work. WIP https://github.com/mudler/luet/tree/fixup_createrepo_metadata

Adds DOWNLOAD_ALL to add old packages back in the index, and enables it
on the publishing pipeline. This will cause the tree to see the old
packages and make them available for installation.

Requires luet 0.17.10

Fixes #602

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Copy link
Contributor Author

mudler commented Sep 20, 2021

ok, tested also manually and should be good. Unfortunately we can't test this on PRs workflow, the publish step runs only on master. It was already green, I've just rebased. Merging

@mudler mudler merged commit 148fab7 into master Sep 20, 2021
@mudler mudler deleted the add_old_packages_to_index branch September 20, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't pin to specified versions because out-of-dated packages are not in the repository
2 participants