Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump luet-makeiso #1188

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Bump luet-makeiso #1188

merged 2 commits into from
Mar 21, 2022

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Mar 21, 2022

Opened to buy us time with CI.

Closes #1148

Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com

@mudler mudler requested review from davidcassany and Itxaka March 21, 2022 08:55
@mudler mudler enabled auto-merge (squash) March 21, 2022 08:55
@mudler
Copy link
Contributor Author

mudler commented Mar 21, 2022

argh, looks like the new luet version has issues with metadata injected by mtree:

/usr/bin/luet create-repo --tree "/runner/_work/cOS-toolkit/cOS-toolkit/packages" \
    --output /runner/_work/cOS-toolkit/cOS-toolkit/build \
    --from-metadata \
    --packages /runner/_work/cOS-toolkit/cOS-toolkit/build \
    --name "cOS" \
    --descr "cOS green" \
    --urls "" \
    --tree-compression zstd \
    --tree-filename tree.tar \
    --meta-compression zstd \
    --type http
 INFO   Repository cOS: creating revision 1 and last update 1647853217...
  ERROR    failed adding Metadata file to repository: error marshaling into JSON: json: unsupported type: map[interface {}]interface {}
panic: fatal error

goroutine 1 [running]:
github.com/mudler/luet/pkg/api/core/logger.(*Logger).Fatal(...)
	/luetbuild/go/src/github.com/mudler/luet/pkg/api/core/logger/logger.go:255
github.com/mudler/luet/cmd/helpers.CheckErr(...)
	/luetbuild/go/src/github.com/mudler/luet/cmd/helpers/cli.go:129
github.com/mudler/luet/cmd.glob..func6(0x15208a0?, {0xdfb4a8?, 0x15?, 0x16?})
	/luetbuild/go/src/github.com/mudler/luet/cmd/create-repo.go:172 +0x11e5
github.com/spf13/cobra.(*Command).execute(0x15208a0, {0xc000442840, 0x15, 0x16})
	/luetbuild/go/src/github.com/mudler/luet/vendor/github.com/spf13/cobra/command.go:860 +0x663
github.com/spf13/cobra.(*Command).ExecuteC(0x151f220)
	/luetbuild/go/src/github.com/mudler/luet/vendor/github.com/spf13/cobra/command.go:974 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
	/luetbuild/go/src/github.com/mudler/luet/vendor/github.com/spf13/cobra/command.go:902
github.com/mudler/luet/cmd.Execute()
	/luetbuild/go/src/github.com/mudler/luet/cmd/root.go:121 +0x37
main.main()

@mudler
Copy link
Contributor Author

mudler commented Mar 21, 2022

Doesn't look related to mtree at all :/

@mudler mudler force-pushed the bump_makeiso branch 3 times, most recently from 9fe4c76 to 271d9ac Compare March 21, 2022 10:26
Closes #1148

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler force-pushed the bump_makeiso branch 3 times, most recently from 5d9b929 to 2ca314c Compare March 21, 2022 15:35
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler merged commit 8a7d731 into master Mar 21, 2022
@mudler mudler deleted the bump_makeiso branch March 21, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated ISOs are not 'valid' hybrid
2 participants