Unflaky ci tests #1204
Merged
Unflaky ci tests #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
added
status/safe to test
mudler
force-pushed
the
unflaky_ci
branch
2 times, most recently
from
989910f to
bd90a20
Compare
mudler
requested review from
Itxaka and
davidcassany
and removed request for
Itxaka
See #1202 Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Also add checksum verification when downloading the blob with curl Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
davidcassany
approved these changes
Mar 25, 2022
Itxaka
reviewed
Mar 25, 2022
| _DOCKER_IMAGE="$REPO_URL:luet-toolchain-$LUET_VERSION" | ||
| echo "Using luet bootstrap version from docker image: ${_DOCKER_IMAGE}" | ||
| docker run --entrypoint /usr/bin/luet --name luet ${_DOCKER_IMAGE} --version | ||
| docker cp luet:/usr/bin/luet ./ |
There was a problem hiding this comment.
should we clean the container afterwards?
Itxaka
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luet. Adds checksum verification and also installation via docker from our repositories which is then forced to be used in our pipelines.Fixes #1202