Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yip #1872

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Bump yip #1872

merged 2 commits into from
Dec 11, 2023

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Dec 11, 2023

The result of:

  • go get github.com/mudler/yip@v1.4.6
  • go mod tidy
  • go vendor

Fixes #1849

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner December 11, 2023 10:04
Signed-off-by: David Cassany <dcassany@suse.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a1b942) 75.96% compared to head (ba9583b) 75.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1872   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files          66       66           
  Lines        6912     6912           
=======================================
  Hits         5251     5251           
  Misses       1290     1290           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany enabled auto-merge (rebase) December 11, 2023 10:35
@davidcassany davidcassany merged commit 7844362 into rancher:main Dec 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bump yip to include https://github.com/mudler/yip/pull/118
3 participants