Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add btrfs support in partitioner #1878

Merged

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Dec 12, 2023

Part of #1874

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner December 12, 2023 16:32
@codecov-commenter
Copy link

Codecov Report

Attention: 359 lines in your changes are missing coverage. Please review.

Comparison is base (840c80c) 75.96% compared to head (a6892f5) 72.53%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/action/mount.go 5.94% 169 Missing and 5 partials ⚠️
cmd/config/config.go 3.50% 55 Missing ⚠️
pkg/config/config.go 15.78% 48 Missing ⚠️
pkg/types/v1/config.go 0.00% 28 Missing ⚠️
cmd/mount.go 23.07% 19 Missing and 1 partial ⚠️
pkg/features/features.go 18.75% 12 Missing and 1 partial ⚠️
pkg/partitioner/disk.go 65.38% 6 Missing and 3 partials ⚠️
pkg/constants/constants.go 0.00% 7 Missing ⚠️
pkg/systemd/unit.go 0.00% 3 Missing ⚠️
cmd/build-disk.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   75.96%   72.53%   -3.44%     
==========================================
  Files          66       69       +3     
  Lines        6912     7286     +374     
==========================================
+ Hits         5251     5285      +34     
- Misses       1290     1622     +332     
- Partials      371      379       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidcassany davidcassany merged commit 39384e0 into rancher:main Dec 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants