Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount readonly EFI partition to /run/elemental/efi #1905

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Jan 17, 2024

Mount EFI partition in running system to /run/elemental/efi.

This enable us to move the boot-assessment grub configuration files into the ESP.

@frelon frelon requested a review from a team as a code owner January 17, 2024 09:32
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0bf2c64) 73.76% compared to head (b5cc0f2) 73.79%.

Files Patch % Lines
pkg/action/mount.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1905      +/-   ##
==========================================
+ Coverage   73.76%   73.79%   +0.02%     
==========================================
  Files          71       71              
  Lines        7749     7757       +8     
==========================================
+ Hits         5716     5724       +8     
  Misses       1612     1612              
  Partials      421      421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon enabled auto-merge (squash) January 17, 2024 10:19
@frelon frelon force-pushed the mount-ro-efi branch 2 times, most recently from 5890199 to 48525ca Compare January 18, 2024 08:59
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frelon frelon merged commit dfb78c7 into rancher:main Jan 18, 2024
14 checks passed
@frelon frelon deleted the mount-ro-efi branch January 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants