Bump twpayne/vfs module to latest version #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frelon
approved these changes
Jan 19, 2024
davidcassany
force-pushed
the
bump_twpayne_vfs
branch
from
c544b10 to
f8963f1
Compare
davidcassany
commented
Jan 19, 2024
davidcassany
force-pushed
the
bump_twpayne_vfs
branch
from
f8963f1 to
fa0c21a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
==========================================
+ Coverage 73.79% 73.83% +0.04%
==========================================
Files 71 71
Lines 7757 7773 +16
==========================================
+ Hits 5724 5739 +15
Misses 1612 1612
- Partials 421 422 +1 ☔ View full report in Codecov by Sentry. |
Specifically bumping from v1.7.2 to v4.3.0. We were pretty outdated. This commit could not get rid of the old version dependency completely because yip requires a vfs v1 within the plugin API and we implement a yip plugin for partitioning in elemental-toolkit. Because of that both versions are coexisting. Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
bump_twpayne_vfs
branch
from
fa0c21a to
8b397c8
Compare
davidcassany
commented
Jan 19, 2024
| Lstat(name string) (os.FileInfo, error) | ||
| RemoveAll(path string) error | ||
| Glob(pattern string) ([]string, error) | ||
| Link(oldname, newname string) error |
There was a problem hiding this comment.
This Link support for hardlinks the main reason for this change. V1 did not include support for hardlinks.
fgiudici
approved these changes
Jan 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically bumping from v1.7.2 to v4.3.0. We were pretty outdated.
This commit could not get rid of the old version dependency completely because yip requires a vfs v1 within the plugin API and we implement a yip plugin for partitioning in elemental-toolkit. Because of that both versions are coexisting.