Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downgrade tests, there are no hooks when upgrading from passive #2004

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

davidcassany
Copy link
Contributor

No description provided.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner March 11, 2024 09:36
@davidcassany davidcassany enabled auto-merge (rebase) March 11, 2024 09:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.53%. Comparing base (0fe9187) to head (efd3044).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2004   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files          76       76           
  Lines        8910     8910           
=======================================
  Hits         6463     6463           
  Misses       1913     1913           
  Partials      534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@davidcassany davidcassany merged commit 31f164a into rancher:main Mar 11, 2024
19 checks passed
@davidcassany davidcassany deleted the fix_downgrade_test branch March 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants