Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test qemu secure boot #2017

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Test qemu secure boot #2017

merged 1 commit into from
Mar 21, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Mar 19, 2024

Add qemu settings for secure boot and add test in smoke suite to actually test that secure boot is enabled.

@frelon frelon force-pushed the test-secureboot branch 2 times, most recently from 318ec88 to 9e66b32 Compare March 20, 2024 07:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.56%. Comparing base (a2c4f0b) to head (9e66b32).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2017   +/-   ##
=======================================
  Coverage   72.56%   72.56%           
=======================================
  Files          76       76           
  Lines        8907     8907           
=======================================
  Hits         6463     6463           
  Misses       1910     1910           
  Partials      534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add qemu settings for secure boot and add test in smoke suite to
actually test that secure boot is enabled.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon
Copy link
Contributor Author

frelon commented Mar 20, 2024

Since the workflow is running from the main branch the updated values of ELMNTL_FIRMWARE_VARS is not used yet.

@frelon frelon marked this pull request as ready for review March 20, 2024 11:55
@frelon frelon requested a review from a team as a code owner March 20, 2024 11:55
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit c0f39f2 into rancher:main Mar 21, 2024
10 of 17 checks passed
@frelon frelon deleted the test-secureboot branch March 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants