Fix passive snapshots listing in grub.cfg #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
commented
Mar 21, 2024
| set mode=passive | ||
| search --no-floppy --label --set=root ${state_label} | ||
| set_volume ${passive_snap} |
There was a problem hiding this comment.
This variable inside the menu is not expanded when looping, in fact it is expanded when choosing the actual menu item and it takes the value of the last assignement in the loop. Should have been passed as an argument to the menuentry call.
| @@ -90,10 +90,10 @@ menuentry "${display_name}" --id active { | |||
| } | |||
|
|
|||
| for passive_snap in ${passive_snaps}; do | |||
| menuentry "${display_name} (snapshot ${passive_snap})" --id ${passive_snap} { | |||
| menuentry "${display_name} (snapshot ${passive_snap})" --id passive${passive_snap} ${passive_snap} { | |||
There was a problem hiding this comment.
Ensuring the ID is not set to a number, as then it turns to be confusing with the fallback values, which is just a counter of the menu items, starting from 0 at top. So if a menu is chosen by ID it will not definitely be a number. If a number is used, then menu counter applies.
fgiudici
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.