Remove default network configuration #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
commented
Mar 25, 2024
| initramfs: | ||
| - name: "Setup network" | ||
| files: | ||
| - path: /etc/sysconfig/network/ifcfg-eth0 |
There was a problem hiding this comment.
Exploring if this setup is actually required. Would be nice if we can get rid of the eth0 literals.
There was a problem hiding this comment.
Good point. If we are using NetworkManager by default, in case no network configuration is available, it will do the "right thing":create a default DHCP connection over available interfaces.
davidcassany
force-pushed
the
remove_network_configuration
branch
from
bff3c71 to
3082a89
Compare
davidcassany
force-pushed
the
remove_network_configuration
branch
from
3082a89 to
5c97738
Compare
fgiudici
approved these changes
Apr 23, 2024
frelon
approved these changes
Apr 26, 2024
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
remove_network_configuration
branch
from
5c97738 to
fe946bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.