Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshottable recovery system #2032

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Mar 25, 2024

Deploy the entire recovery system to the same folder (kernel, initrd and rootfs).

During upgrade deploy to a transitional folder and then switch it with the current recovery system and then delete the old one.

This makes sure we clean up old recovery systems and don't risk mixing systems during upgrade.

Fixes #2021

@frelon frelon force-pushed the snapshot-recovery-upgrade branch 2 times, most recently from 8e59d48 to ca36a26 Compare March 26, 2024 09:39
@frelon frelon marked this pull request as ready for review March 26, 2024 09:40
@frelon frelon requested a review from a team as a code owner March 26, 2024 09:40
@frelon frelon force-pushed the snapshot-recovery-upgrade branch from ca36a26 to 533f508 Compare March 26, 2024 14:23
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like some unit tests needs to be arranged though.

@frelon frelon force-pushed the snapshot-recovery-upgrade branch 3 times, most recently from bc3819b to 13f422d Compare March 28, 2024 12:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 52.11268% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 72.15%. Comparing base (88a9d0c) to head (0004d1b).

Files Patch % Lines
pkg/action/upgrade-recovery.go 39.02% 22 Missing and 3 partials ⚠️
pkg/elemental/elemental.go 40.00% 5 Missing and 1 partial ⚠️
cmd/build-iso.go 0.00% 1 Missing ⚠️
pkg/config/config.go 85.71% 0 Missing and 1 partial ⚠️
pkg/utils/fs.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
- Coverage   72.36%   72.15%   -0.21%     
==========================================
  Files          76       76              
  Lines        9021     9043      +22     
==========================================
- Hits         6528     6525       -3     
- Misses       1949     1973      +24     
- Partials      544      545       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon force-pushed the snapshot-recovery-upgrade branch from 13f422d to dbf6d97 Compare March 28, 2024 14:52
frelon added 2 commits April 3, 2024 11:11
Deploy the entire recovery system to the same folder (kernel, initrd and
rootfs).

During upgrade deploy to a transitional folder and then switch it with
the current recovery system and then delete the old one.

This makes sure we clean up old recovery systems and don't risk mixing
systems during upgrade.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
One too many boot/ snuck into the upgrade spec.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon force-pushed the snapshot-recovery-upgrade branch from dbf6d97 to 0004d1b Compare April 3, 2024 09:11
@frelon frelon merged commit 127fa52 into rancher:main Apr 5, 2024
17 checks passed
@frelon frelon deleted the snapshot-recovery-upgrade branch April 5, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot recovery upgrade
3 participants