Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra-cmdline flag to build-iso command #2072

Merged
merged 2 commits into from
May 10, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented May 8, 2024

The extra-cmdline can be used to customize the kernel commandline used
for the ISO.

Some arbitrary flags were moved to the extra-cmdline in order to support
overriding security and consoles.

Signed-off-by: Fredrik Lönnegren fredrik.lonnegren@suse.com

@frelon frelon requested a review from a team as a code owner May 8, 2024 13:52
@frelon frelon linked an issue May 8, 2024 that may be closed by this pull request
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small details regarding where to set the default value.

cmd/build-iso.go Outdated Show resolved Hide resolved
frelon added 2 commits May 10, 2024 13:44
The extra-cmdline can be used to customize the kernel commandline used
for the ISO.

Some arbitrary flags were moved to the extra-cmdline in order to support
overriding security and consoles.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon force-pushed the build-iso-cmdline branch from 5843f18 to 4c4624a Compare May 10, 2024 11:44
@frelon frelon merged commit a4c414f into rancher:main May 10, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set kernel-parameters for build-iso
2 participants