Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ELEMENTAL_CLOUD_INIT_PATHS option #2163

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

anmazzotti
Copy link
Contributor

This adds the --cloud-init-paths argument for all elemental cli subcommands. This was previously added only for build-disk, but I find it useful in all other cases.

The ELEMENTAL_CLOUD_INIT_PATHS env variable is also added to achieve the same effect.

The reason to introduce this feature is to address corner cases when using after-install and after-reset, especially the latter since in the default Elemental images, /system/oem and /usr/local/cloud-config are read only, and /oem is going to be formatted before being evaluated.

Having a dynamic path to be evaluated at run time allows for more freedom.

This is also an enabler for rancher/elemental-operator#806

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti requested a review from a team as a code owner August 19, 2024 11:36
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert but I don't see anything that could break the toolkit, so LGTM.

@anmazzotti anmazzotti merged commit b1bac09 into rancher:main Aug 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants