Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable network in initrd and disable selinux #2170

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Sep 2, 2024

This PR includes three independent changes (and a commit for each):

  1. Disables enforce mode for SELINUX. Dbus service in green example started to fail due to some SELINUX denials. Until this is fixed and further analyzed we switch to permissive mode.
  2. Fixes the recovery tests, we realized they were not testing the right system, upgrading recovery was performed from a downgraded system as a result of the previous test.
  3. Disables network setup in initrd. This turned to be buggy lately, despite not causing an explicit failure it causes the system to be stuck for around 90s at boot (probably related to this issue: dbus in the initrd just like this is a bad idea dracutdevs/dracut#2378 ), this can be seen on CI tests timing, as suddenly tests started to last way longer, compare the timing in this run and this other one without NM in initrd.

All of them are currenltye required to turn the CI back to green with the expected performance.

@davidcassany davidcassany requested a review from a team as a code owner September 2, 2024 20:54
@davidcassany davidcassany marked this pull request as draft September 2, 2024 20:55
@davidcassany davidcassany force-pushed the fix_ci_draft branch 2 times, most recently from 52fba0e to c914a1d Compare September 4, 2024 15:36
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany marked this pull request as ready for review September 4, 2024 16:35
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany merged commit 5e0a28c into rancher:main Sep 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants