Use latest snapper installation helper #2246
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
commented
Dec 16, 2024
| return &snapperBackend{cfg: cfg, maxSnapshots: maxSnapshots, btrfs: newBtrfsBackend(cfg, maxSnapshots)} | ||
|
|
||
| // TODO detect wheather the current snapper supports the required installation helper | ||
| return &snapperBackend{cfg: cfg, maxSnapshots: maxSnapshots, btrfs: nil} |
There was a problem hiding this comment.
We should initiate btrfs backend if snapper does not support the latest installation helper and use it instead
There was a problem hiding this comment.
The PR is blocked until a new snapper version is released in TW. Then addressing this TODO will be needed.
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
new_snapper
branch
from
1b57b94 to
6e398a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the installation helper the btrfs backend instance is no longer required in snapper backend implementation.
This PR adopts the upstream changes in snapper to fix openSUSE/snapper#944