Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jq: build arm64 version #666

Merged
merged 4 commits into from
Sep 22, 2021
Merged

jq: build arm64 version #666

merged 4 commits into from
Sep 22, 2021

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Sep 20, 2021

Default version was taking the x86_64 binary release from github for all
arches.

This patch downloads the git repo and builds the binary for arm64 if the
arch is set

Signed-off-by: Itxaka igarcia@suse.com

@Itxaka Itxaka added the arm64 label Sep 20, 2021
@Itxaka Itxaka requested a review from mudler September 20, 2021 12:32
@mudler
Copy link
Contributor

mudler commented Sep 20, 2021

Nice! Maybe we can also go building with amd64 too?

@Itxaka
Copy link
Contributor Author

Itxaka commented Sep 20, 2021

cancelled arm64 job until master pushed latest packages of all artifacts. No point building everything here again because we are missing artifacts.

@Itxaka Itxaka enabled auto-merge (squash) September 20, 2021 14:59
Itxaka added 3 commits September 22, 2021 13:08
Default version was taking the x86_64 binary release from github for all
arches.

This patch downloads the git repo and builds the binary for arm64 if the
arch is set

Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
@mudler
Copy link
Contributor

mudler commented Sep 22, 2021

We had a green build with both arm and amd64, and there are no tests explictly leveraging jq as it is not installed. It is just consumed by the CI, so I would merge it without waiting tests

@Itxaka Itxaka disabled auto-merge September 22, 2021 14:16
@Itxaka Itxaka merged commit 21a55df into rancher:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants