ci: reattempt download on failure with a backoff sleep time #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #675 Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Itxaka
approved these changes
Sep 21, 2021
| @@ -22,7 +23,18 @@ type resultData struct { | |||
| Exists bool | |||
| } | |||
|
|
|||
| func downloadImage(img, dst string) error { | |||
| func retryDownload(img, dest string, t int) error { | |||
| if err := download(img, dest); err != nil { | |||
There was a problem hiding this comment.
Should we check here if the error is actually retryable?
There was a problem hiding this comment.
not really sure if it's worth adding complexity here for a retry... it might just fail for downloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com