Setup installer testing #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
reviewed
Nov 8, 2021
| s.GatherAllLogs() | ||
| } else { | ||
| // Trash disk so we boot from iso after each test | ||
| s.EmptyDisk("/dev/sda") |
There was a problem hiding this comment.
maybe we should empty the disk before each one? Otherwise it depends from the first one to be able to run successfully (and can be a bit confusing?)
mudler
reviewed
Nov 8, 2021
tests/installer/installer_test.go
Outdated
| }) | ||
| Context("Using legacy bios", func() { | ||
| Context("generic tests", func() { | ||
| It("booted from iso", func() { |
There was a problem hiding this comment.
mmm and maybe we can do these assertion right after we empty the disk, before each suite?
mudler
approved these changes
Nov 8, 2021
|
Overall looks good! 💯 |
2 tasks
added 8 commits
November 10, 2021 13:41
- Add make target for creating a vm from the iso - Add some generic tests to check if we booted from cd - Add placeholders for future tests for installer Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Now we have 2 different paths to test both boot methods. Both paths have distinct setups as they differ a bit in the boot steps Signed-off-by: Itxaka <igarcia@suse.com>
Both iso and efi can now run Signed-off-by: Itxaka <igarcia@suse.com>
Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
setup_iso_testing
branch
from
9f98cc6 to
3260635
Compare
Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
setup_iso_testing
branch
from
2612fb5 to
976e5f6
Compare
Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
setup_iso_testing
branch
from
976e5f6 to
b98600b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.