Allow to specify an image to cos-installer #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
cos-install-image
branch
11 times, most recently
from
977c4be to
da3080a
Compare
|
@Itxaka should be good for a first review. Tests are still not passing, but I think I've got almost all of them fixed in the last push |
mudler
commented
Nov 11, 2021
mudler
force-pushed
the
cos-install-image
branch
from
5cbb60f to
8e8441f
Compare
|
Looking good to me for now. Do you plan to add tests to the installer for this new feature? 😉 |
I thought at it, but then, the feature is actually tested by cos-deploy tests |
mudler
force-pushed
the
cos-install-image
branch
3 times, most recently
from
49c0099 to
7348bec
Compare
|
@Itxaka deploy-image and raw deploy tests passed 🎉 (there was just some flakyness, as some failed for network issues :/ ) |
Itxaka
approved these changes
Nov 11, 2021
mudler
force-pushed
the
cos-install-image
branch
from
63e2616 to
5f56adf
Compare
mudler
force-pushed
the
cos-install-image
branch
2 times, most recently
from
44fcd1c to
632d766
Compare
- Make sure to find installation channel only if we are booting from live or we provide an image - Prepare recovery only if we are not booting from it - Don't try to find upgrade channel if we specified an ISO url Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler
force-pushed
the
cos-install-image
branch
from
632d766 to
5911138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making
cos-installercapable to take container images in place of the ISO content, we are untying the installer from the ISO. This has two benefit:cos-deploywas partially crossing withcos-installer. The only difference is thatcos-deploydoesn't format, and just copy an image during install, which nowcos-installeris capable of too as well.This commit drops cos-deploy * logics, but keeps the wrapper by calling
cos-installeraccordingly.Additionally, cos-installer now accepts:
--docker-image,--no-verifyand--no-cosign