Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages documentation #907

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Add packages documentation #907

merged 3 commits into from
Dec 3, 2021

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Nov 30, 2021

This is just adding some placeholders, I'll add up docs but wanted to have all in place and see how it looks like
before going ahead

Part of: #757

@mudler mudler changed the title WIP: Add docs for immutable-rootfs package WIP: Add packages documentation Nov 30, 2021
@davidcassany
Copy link
Contributor

@mudler JFYI in #909 I am doing little cleanup on packages deps and I saw there is not need for a collection here as we are building a single package. I moved the collection.yaml to a definition.yaml.

@mudler
Copy link
Contributor Author

mudler commented Dec 2, 2021

yep, noticed the same here indeed and I swapped it into a package 😄 , no worries, I can re-adapt after your PR is merged 👍

@mudler
Copy link
Contributor Author

mudler commented Dec 2, 2021

ok, reworked out so it just applies the README.md file and leaves the specs untouched so it's easier to rebase later

mudler added a commit to rancher-sandbox/cos-toolkit-docs that referenced this pull request Dec 3, 2021
This PR introduce a script which generates layout/structure to be parsed
from our docs to be displayed in the website. It parses the cos-toolkit
repository packages and scans for `README.md` files present in the
package path (where `build.yaml` and `definition.yaml` reside).

If it's a collection, it still reads for README files, but allows also
to generate per-package documentation by checking the presence of
`README-cat-name.md` in the package path, if present it will create a
new grouped page and put the packages of the collection under it.

In order to preserve readability on cos-toolkit side, the page header of
a collection cannot be generated cleanly, so a `README-head.md` file is
required with the specific docsy fields, e.g:

```yaml
---
title: "Collection name"
linkTitle: "Collection title"
date: 2021-12-02
description: >
  Collection description
---
```

Needs: rancher/elemental-toolkit#907
Part of: rancher/elemental-toolkit#757

Add makefile target and hook into CI

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler changed the title WIP: Add packages documentation Add packages documentation Dec 3, 2021
@mudler mudler marked this pull request as ready for review December 3, 2021 09:09
Ported over from the docs website

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler linked an issue Dec 3, 2021 that may be closed by this pull request
@mudler mudler merged commit 5f684e1 into master Dec 3, 2021
@mudler mudler deleted the package_docs branch December 3, 2021 17:55
@mudler
Copy link
Contributor Author

mudler commented Dec 3, 2021

Just moved some docs and added placeholders. merging because it is tight with the other PR, and docs were now missing from the website 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document core packages
2 participants