Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt bootargs file to support btrfs snapshotter #1213

Merged

Conversation

davidcassany
Copy link
Contributor

No description provided.

@davidcassany davidcassany requested a review from a team as a code owner February 14, 2024 11:01
@davidcassany davidcassany marked this pull request as draft February 14, 2024 11:01
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidcassany davidcassany force-pushed the update_to_new_elemental-toolkit branch 3 times, most recently from 5f3c3b7 to 145d3a7 Compare February 14, 2024 16:18
@frelon frelon changed the title Adapt bootlargs file to support btrfs snapshotter Adapt bootargs file to support btrfs snapshotter Feb 15, 2024
@davidcassany davidcassany marked this pull request as ready for review February 16, 2024 16:14
@davidcassany davidcassany force-pushed the update_to_new_elemental-toolkit branch from 145d3a7 to bbd3aaa Compare February 16, 2024 16:14
@davidcassany
Copy link
Contributor Author

Requires rancher/elemental-toolkit#1957 to merged first/together

@davidcassany davidcassany force-pushed the update_to_new_elemental-toolkit branch from bbd3aaa to a3435cf Compare February 19, 2024 07:06
@@ -44,6 +44,9 @@ RUN zypper --installroot /osimage in --no-recommends -y apparmor-parser
# add elemental
RUN zypper --installroot /osimage in --no-recommends -y elemental

# add transactional updates utilities
RUN zypper --installroot /osimage in --no-recommends -y transactional-update
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transactional update stack added here to be capable to explore the possibility of running elemental upgrade and transactional updates over the same system without breaking the system.

IMHO, this is a nice to have not mandatory urgent goal. Adding it here allows us to verify installing it does not break anything and it also allows to easily manually test it afterwards. I don't think it will work out of the box as the mount layout between SLE Micro and Elemental is slightly different (slightly different assumptions on /var and on /etc).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this change as I could actually validate transactional-update is not functional. Snapper is, but not transactional-update, libtukit fails as it has some expectations on the underlaying layout which are not met (mostly around /var and /etc paths).

Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the update_to_new_elemental-toolkit branch from a3435cf to 6edd43f Compare February 21, 2024 11:01
@davidcassany davidcassany merged commit 95886d2 into rancher:main Feb 21, 2024
6 of 7 checks passed
@davidcassany davidcassany deleted the update_to_new_elemental-toolkit branch February 21, 2024 13:06
kkaempf pushed a commit that referenced this pull request Mar 5, 2024
* Adapt bootlargs file to support btrfs snapshotter

Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants