-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt bootargs file to support btrfs snapshotter #1213
Adapt bootargs file to support btrfs snapshotter #1213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5f3c3b7
to
145d3a7
Compare
145d3a7
to
bbd3aaa
Compare
Requires rancher/elemental-toolkit#1957 to merged first/together |
bbd3aaa
to
a3435cf
Compare
@@ -44,6 +44,9 @@ RUN zypper --installroot /osimage in --no-recommends -y apparmor-parser | |||
# add elemental | |||
RUN zypper --installroot /osimage in --no-recommends -y elemental | |||
|
|||
# add transactional updates utilities | |||
RUN zypper --installroot /osimage in --no-recommends -y transactional-update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transactional update stack added here to be capable to explore the possibility of running elemental upgrade and transactional updates over the same system without breaking the system.
IMHO, this is a nice to have not mandatory urgent goal. Adding it here allows us to verify installing it does not break anything and it also allows to easily manually test it afterwards. I don't think it will work out of the box as the mount layout between SLE Micro and Elemental is slightly different (slightly different assumptions on /var
and on /etc
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted this change as I could actually validate transactional-update is not functional. Snapper is, but not transactional-update, libtukit fails as it has some expectations on the underlaying layout which are not met (mostly around /var and /etc paths).
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
This reverts commit a3435cf.
a3435cf
to
6edd43f
Compare
* Adapt bootlargs file to support btrfs snapshotter Signed-off-by: David Cassany <dcassany@suse.com>
No description provided.