-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k3s images #26
Add k3s images #26
Conversation
I believe yhese images were previously pushed manually by @cjellick Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Not sure if we typically prepend k8s.gcr to the repo like we do with others, but I suppose since these are pre-existing we won't do that.
OK. I actually need to merge the multiarch PR #27 first, as the current script will overwrite the manually-pushed multiarch ones when I merge this one. I know that one's potentially a much bigger deal. |
@@ -46,3 +46,6 @@ directxman12/k8s-prometheus-adapter-amd64 rancher/directxman12-k8s-prometheus-ad | |||
bats/bats rancher/bats-bats v1.1.0 | |||
curlimages/curl rancher/curlimages-curl 7.70.0 | |||
busybox rancher/busybox 1.31.1 | |||
coredns/coredns rancher/coredns-coredns 1.6.9 | |||
k8s.gcr.io/metrics-server/metrics-server rancher/metrics-server v0.3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does coredns/coredns go to rancher/coredns-coredns
but metrics server doesn't go to rancher/metrics-server-metrics-server
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have many questions about the lack of conventions in the image mirror.
- library/nginx goes to rancher/nginx but should have been rancher/library-nginx.
- busybox is really library/busybox (no registry, no repo = docker.io/library/) but goes to just rancher/busybox.
- us.gcr.io/k8s-artifacts-prod/external-dns/external-dns is rancher/kubernetes-external-dns - not even the same name!
- coredns/coredns went to rancher/coredns-coredns. We also have rancher/coredns which is our fips-140 build of coredns/coredns. I only know that because I asked.
- k3s uses rancher/metrics-server (has been for a while), even though it should have been rancher/metrics-server-metrics-server (as you point out). Our v0.3.6 tag is also a multiarch manifest list, while upstream v0.3.6 (only available on the old location of gcr.io/google_containers/metrics-server) is amd64 only, although there are v0.3.6-arm64 and v0.3.6-arm tags available with the appropriate architectures. I've sidestepped this by going to v0.3.7 which is multiarch upstream at the current location. This one is real bad.
I opened an issue to suggest that we move our mirrored stuff out to a dedicated org, and @cjellick was going to work on moving our hardened images to another org at some point as well. Right now everything's all mushed in together and it's challenging to pick apart because we've already got references to the current mishmash embedded in a bunch of supported releases.
@@ -46,3 +46,6 @@ directxman12/k8s-prometheus-adapter-amd64 rancher/directxman12-k8s-prometheus-ad | |||
bats/bats rancher/bats-bats v1.1.0 | |||
curlimages/curl rancher/curlimages-curl 7.70.0 | |||
busybox rancher/busybox 1.31.1 | |||
coredns/coredns rancher/coredns-coredns 1.6.9 | |||
k8s.gcr.io/metrics-server/metrics-server rancher/metrics-server v0.3.7 | |||
k8s.gcr.io/pause rancher/pause 3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already exists in DockerHub and is multi-arch:
https://hub.docker.com/repository/docker/rancher/pause/tags?page=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it was pushed manually by @ibuildthecloud a year ago. Should be automated.
@@ -46,3 +46,6 @@ directxman12/k8s-prometheus-adapter-amd64 rancher/directxman12-k8s-prometheus-ad | |||
bats/bats rancher/bats-bats v1.1.0 | |||
curlimages/curl rancher/curlimages-curl 7.70.0 | |||
busybox rancher/busybox 1.31.1 | |||
coredns/coredns rancher/coredns-coredns 1.6.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version already exists in Dockerhub and is multi-arch:
https://hub.docker.com/repository/docker/rancher/coredns-coredns/tags?page=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it was pushed manually by @cjellick. Should be automated.
In a side note, I added the automated publisher perms to all of these repos for whenever we want to have drone build/push these images. |
I just moved this back to draft to prevent merging until the mirror script is updated to support multiarch. |
What's the status of this PR? |
Will review soon. I've been focused on RKE2 GA tasks. |
I believe these images were previously pushed manually by @cjellick
Signed-off-by: Brad Davidson brad.davidson@rancher.com