Schema leak #522
Merged
Schema leak #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeranda
force-pushed
the
schema-leak
branch
from
1773c74 to
6c28360
Compare
aruiz14
reviewed
Oct 29, 2024
aruiz14
approved these changes
Oct 30, 2024
nflynt
previously approved these changes
Oct 30, 2024
ericpromislow
requested changes
Nov 25, 2024
joshmeranda
force-pushed
the
schema-leak
branch
from
335ac95 to
dce6002
Compare
nflynt
approved these changes
Nov 25, 2024
crobby
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We neglect to remove schemas from
s.schemasins.doRemoveSchemawhich results in duplicate entries ins.schemaswhich are never removed. This introduces a memory leak of ~300 mb a week on a large rancher cluster.rancher/rancher#47694