-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Etcd snapshot trying too frequently #153
Etcd snapshot trying too frequently #153
Conversation
5c80e10
to
a2cf7c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM.
main.go
Outdated
return client, nil | ||
} | ||
|
||
func CreateBackup(backupName, etcdCACert, etcdCert, etcdKey, endpoints string, backupRetries, s3Retries int) (compressedFilePath string, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the parameters3Retries
is not used in the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good catch!
a2cf7c5
to
a62e5ca
Compare
a62e5ca
to
a9ba50d
Compare
Added optimistic checking of s3 bucket for existing snapshot and versioning enabled before attempting multiple uploads. Update minio client to v7
a9ba50d
to
5eb3ae8
Compare
Also force pushing for this big of a PR is pretty confusing for reviewers. I know we have the compare button, but an extra commit with changes would be helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
rancher/rancher#37639
storage.googleapis.com
. I tested this with a bucket in GCP, and it worked fine with the v2 s3 API, so whatever requirement drove that is no longer valid.