Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entrypoint.sh for kubelet on cri-dockerd #165

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix entrypoint.sh for kubelet on cri-dockerd #165

merged 1 commit into from
Sep 19, 2023

Conversation

Thiryn
Copy link
Contributor

@Thiryn Thiryn commented Jul 11, 2023

This PR is related to rancher/rke#3292

Adding an exit after the wait -n ensures the program's exit after either cri-dockerd or kubelet exits.
Most likely was an oversight on wait's behaviour as the comment mentions waiting for either cri-dockerd or kubelet to crash and exit.

This change prevents the L114 exec "$@" to be executed after cri-dockerd or kubelet exits.

@Thiryn Thiryn mentioned this pull request Jul 11, 2023
Closed
@superseb superseb requested a review from a team September 12, 2023 09:19
@superseb superseb merged commit 68fc706 into rancher:master Sep 19, 2023
@Thiryn Thiryn deleted the fix-entrypoint-exit branch September 19, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superseb superseb superseb approved these changes

@kinarashah kinarashah Awaiting requested review from kinarashah

@jakefhyde jakefhyde Awaiting requested review from jakefhyde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thiryn @superseb