-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated incorrect CIS controls Ids and version mapping #174
Conversation
@@ -1,6 +1,6 @@ | |||
--- | |||
controls: | |||
version: "cis-1.23" | |||
version: 1.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiranBodipi regarding the version name, I agree we should stick to kube-bench's format which uses version: cis-1.X
and not version: 1.x
.
IMO the cis-benchmark chart (or any other components) use cfgs filenames, so setting back the naming convention to version: cis-1.X in the yamls should be fine.
@rayandas could you confirm this ?
If we all approve this, let's change all files to use version: cis-1.X
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we normally follow version: 1.x
only. But I saw for a few configs there are version: cis-1.x
which we can change to version: 1.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can keep all the configs as version: cis-1.x
same as kube-bench. It shouldn’t impact anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified my first comment ^, kube-bench actually uses version: cis-1.x
and not version: 1.x
. We will have another PR to adjust all yamls to have version: cis-1.x
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised rancher/cis-operator#248 to track the changes. Someone from my team will take it up.
@rayandas we will make another PR to include @KiranBodipi's changes and adjust all yamls to have |
updated the scripts with correct CIS control Ids for controls Ids and version mapping