Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projectsornamespaces query parameter #105

Merged
merged 1 commit into from
May 12, 2023

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented May 10, 2023

Add a new query parameter to filter resources by their namespace or their namespace's project. This parameter is separate from the existing filter parameter.

Filter by a comma-separated list of projects and/or namespaces with:

?projectsornamespaces=p1,n1,n2

The result can be negated with the ! operator:

?projectsornamespaces!=p1,n1,n2

rancher/rancher#40140

@cmurphy cmurphy force-pushed the projects-filtering branch from f190778 to 43d57ac Compare May 10, 2023 22:58
@MbolotSuse MbolotSuse self-requested a review May 11, 2023 16:54
Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of mostly small items, overall the approach is very readable and well put-together.

pkg/stores/partition/listprocessor/processor.go Outdated Show resolved Hide resolved
pkg/stores/partition/listprocessor/processor.go Outdated Show resolved Hide resolved
Add a new query parameter to filter resources by their namespace or
their namespace's project. This parameter is separate from the existing
`filter` parameter.

Filter by a comma-separated list of projects and/or namespaces with:

?projectsornamespaces=p1,n1,n2

The result can be negated with the ! operator:

?projectsornamespaces!=p1,n1,n2
Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmurphy cmurphy merged commit 1dfd3c7 into rancher:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants