Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.7 Updating ByNames to not return nil, nil #145

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Backport 2.7 Updating ByNames to not return nil, nil #145

merged 3 commits into from
Jan 30, 2024

Conversation

MbolotSuse
Copy link
Contributor

@MbolotSuse MbolotSuse commented Jan 17, 2024 •
edited
Loading

Backports a few PRs to the release/v2.7 line:

Some small changes were made in comparison to the 2.8 PR. Notably:

@MbolotSuse
Updating ByNames to not return nil, nil
0a75101 
ByNames could previously return a nil value and a nil error. This caused
issues when other parts of the application
(pkg/stores/partition/parallel.go) tried to use the result. Now this
will return an empty list on the error condition, instead of nil
@MbolotSuse MbolotSuse requested review from tomleb and removed request for KevinJoiner January 29, 2024 18:29
@vardhaman22 @MbolotSuse
updated deps for k8s 1.27
4247cfa
@vardhaman22 @MbolotSuse
skip linting rules
fd1e4cf 
these linting rules are enabled by default now in latest golangci-lint revive pluign
@MbolotSuse MbolotSuse changed the title [DRAFT] Backport 2.7 Updating ByNames to not return nil, nil Backport 2.7 Updating ByNames to not return nil, nil Jan 30, 2024
@MbolotSuse MbolotSuse merged commit 0bbb446 into rancher:release/v2.7 Jan 30, 2024
1 check passed
@MKlimuszka MKlimuszka mentioned this pull request Feb 2, 2024
Closed
@MbolotSuse MbolotSuse mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleb tomleb tomleb approved these changes

@rmweir rmweir Awaiting requested review from rmweir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MbolotSuse @tomleb @vardhaman22